refactor/bytes #88
Merged
refactor/bytes #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors byte handling utilities to leverage the Effect library's built-in Schema.Uint8ArrayFromHex schema instead of custom implementations. The changes eliminate redundant code, improve maintainability, and standardize hex-to-bytes conversions across the codebase.
Key Changes:
- Replaced custom
Bytes.FromHexwithSchema.Uint8ArrayFromHexthroughout the codebase - Simplified byte utility modules by removing custom hex validation and conversion logic
- Updated equality function naming from
bytesEqualstoequalsfor consistency - Refactored various BytesN modules to use simpler schema compositions
Reviewed changes
Copilot reviewed 300 out of 359 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/evolution/src/core/Bytes.ts |
Removed extensive custom hex conversion logic; simplified to use Effect's native schemas |
packages/evolution/src/core/EnterpriseAddress.ts |
Updated to use Schema.Uint8ArrayFromHex instead of Bytes.FromHex |
packages/evolution/src/core/Ed25519Signature.ts |
Changed equality check to use Bytes.equals |
packages/evolution/src/core/DnsName.ts |
Refactored to use simplified Text128 schemas and point-free function style |
packages/evolution/src/core/DataJson.ts |
Introduced local HEX_REGEX to replace Bytes.isHex |
packages/evolution/src/core/CBOR.ts |
Updated CBOR hex conversion to use Schema.Uint8ArrayFromHex and Bytes.fromHex |
packages/evolution/src/core/Bytes96.ts |
Simplified schema definitions by removing custom transformation logic |
packages/evolution/src/core/Combinator.ts |
Replaced Bytes.isHex with local HEX_REGEX.test |
| Various address/certificate files | Consistently updated to use Schema.Uint8ArrayFromHex |
| Documentation files | Updated nav_order values and type signatures to reflect schema changes |
packages/evolution/package.json |
Added @emurgo/cardano-message-signing-nodejs dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Update Text.toBytesUnsafe to Text.toBytes - UTF-8 encoding matches Aiken spec
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.